RFR: 8261921: ClassListParser::current should be used only by main thread [v2]

[Ioi Lam]

On Fri, 19 Feb 2021 01:14:45 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into 8261921-classlistparser-only-main-thread
>>  - changed _parsing_thread to volatile
>>  - 8261921: ClassListParser::current should be used only by main thread
>
> src/hotspot/share/classfile/systemDictionary.cpp line 373:
> 
>> 371:     // Special processing for handling UNREGISTERED shared classes.
>> 372:     InstanceKlass* k = SystemDictionaryShared::lookup_super_for_unregistered_class(class_name,
>> 373:                            super_name, is_superclass);
> 
> Please align `super_name` with `class_name` in the previous line.

Fixed.

> src/hotspot/share/classfile/classListParser.hpp line 86:
> 
>> 84:   };
>> 85: 
>> 86:   static Thread* _parsing_thread;    // the thread that created _instance
> 
> Should this be declared `volatile`?

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2619