RFR: 8262157: LingeredApp.startAppExactJvmOpts does not print app output when launching fails

[David Holmes]

Hi Yumin,

Isn't this a serviceability test utility?

Cheers,
David

On 23/02/2021 11:39 am, Yumin Qi wrote:
> Hi, Please review
> 
>   When debugging for other test case which uses jcmd to attach LingeredApp process, found there is no error information logged when the app started with function 'startAppExactJvmOpts' exits due to some reason. This is not convenient for trace what is the app failure.
>   This simple fix for adding finishApp to print out error information when LingeredApp could not start with startAppExactJvmOpts, this is similar to startApp.
> 
> Tests: This is a simple fix and done tests with test/jdk/sun/tools/jinfo which uses the function startAppExactJvmOpts to create LingeredApp, also the test case in debugging, which indeed captured the error message upon start error.
> 
> Thanks
> Yumin
> 
> -------------
> 
> Commit messages:
>   - 8262157: LingeredApp.startAppExactJvmOpts does not print app output when launching fails
> 
> Changes: https://git.openjdk.java.net/jdk/pull/2679/files
>   Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2679&range=00
>    Issue: https://bugs.openjdk.java.net/browse/JDK-8262157
>    Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
>    Patch: https://git.openjdk.java.net/jdk/pull/2679.diff
>    Fetch: git fetch https://git.openjdk.java.net/jdk pull/2679/head:pull/2679
> 
> PR: https://git.openjdk.java.net/jdk/pull/2679
>