RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages

Ioi Lam iklam at openjdk.java.net
Tue Feb 23 17:50:44 UTC 2021


On Tue, 23 Feb 2021 17:32:44 GMT, Yumin Qi <minqi at openjdk.org> wrote:

> Is?
> `#if (defined(LINUX) || defined(__APPLE__)) && defined(AARCH64) or #if (defined(LINUX) && defined(AARCH64)) || defined(__APPLE__)`

Actually, I think we should use

#if (defined(LINUX) && defined(AARCH64)) || (defined(__APPLE__) && defined(AMD64))`

For the macOS case, we are running an AMD64 binary inside Rosetta.

We don't need to worry about `(defined(__APPLE__) && defined(AARCH64))` because we cannot run M1 binaries on AMD64.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2651


More information about the hotspot-runtime-dev mailing list