RFR: 8262099: jcmd VM.metaspace should report unlimited size if MaxMetaspaceSize isn't specified [v4]

[Lutz Schmidt]

On Tue, 23 Feb 2021 02:15:02 GMT, Yi Yang <github.com+5010047+kelthuzadx at openjdk.org> wrote:

>> Hi,
>> 
>> Can I have a review of this minor fix about `jcmd VM.metaspace`?
>> 
>> When MaxMetaspaceSize is not specified, it would set to max_uintx, jcmd VM.metaspace reports metaspace summary information as follows:
>> 
>> $ ./jcmd <pid> VM.metaspace | grep MaxMetaspaceSize
>> MaxMetaspaceSize: 17179869184.00 GB
>> 
>> Actually, this is a bug, the expected output should be:
>> 
>> MaxMetaspaceSize: unlimited
>> 
>> The root cause of the problem is that the MaxMetaspaceSize rounding performed during arguments parsing is inconsistent with the round checking in print_settings(metaspaceRerporter.cpp).
>
> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   IANAL, keep SAP copyright year unchanage

Changes look good to me. 
Thanks for fixing. I was complaining about the, well, awful printout at another place.

-------------

Marked as reviewed by lucy (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2671