Integrated: 8262099: jcmd VM.metaspace should report unlimited size if MaxMetaspaceSize isn't specified

Yi Yang github.com+5010047+kelthuzadx at openjdk.java.net
Thu Feb 25 02:11:44 UTC 2021


On Mon, 22 Feb 2021 03:21:45 GMT, Yi Yang <github.com+5010047+kelthuzadx at openjdk.org> wrote:

> Hi,
> 
> Can I have a review of this minor fix about `jcmd VM.metaspace`?
> 
> When MaxMetaspaceSize is not specified, it would set to max_uintx, jcmd VM.metaspace reports metaspace summary information as follows:
> 
> $ ./jcmd <pid> VM.metaspace | grep MaxMetaspaceSize
> MaxMetaspaceSize: 17179869184.00 GB
> 
> Actually, this is a bug, the expected output should be:
> 
> MaxMetaspaceSize: unlimited
> 
> The root cause of the problem is that the MaxMetaspaceSize rounding performed during arguments parsing is inconsistent with the round checking in print_settings(metaspaceRerporter.cpp).

This pull request has now been integrated.

Changeset: 3a0d6a64
Author:    Yang Yi <qingfeng.yy at alibaba-inc.com>
Committer: David Holmes <dholmes at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/3a0d6a64
Stats:     41 lines in 2 files changed: 24 ins; 1 del; 16 mod

8262099: jcmd VM.metaspace should report unlimited size if MaxMetaspaceSize isn't specified

Reviewed-by: stuefe, lucy

-------------

PR: https://git.openjdk.java.net/jdk/pull/2671


More information about the hotspot-runtime-dev mailing list