RFR: 8241403: JavaThread::get_thread_name() should be ThreadSMR-aware [v6]

[Daniel D.Daugherty]

On Thu, 25 Feb 2021 22:49:32 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address dholmes-ora CR3 comments.
>
> src/hotspot/share/compiler/compileBroker.cpp line 1028:
> 
>> 1026:       assert(ct != NULL, "should have been handled for initial thread");
>> 1027:       ThreadsListHandle tlh;  // get_thread_name() depends on the TLH.
>> 1028:       assert(tlh.includes(ct), "ct=" INTPTR_FORMAT " exited unexpectedly.", p2i(ct));
> 
> This can be placed inside the if-clause where the MutexLocker was.

True. That would be better.

> src/hotspot/share/compiler/compileBroker.cpp line 1115:
> 
>> 1113:       if (ct == NULL) break;
>> 1114:       ThreadsListHandle tlh;  // get_thread_name() depends on the TLH.
>> 1115:       assert(tlh.includes(ct), "ct=" INTPTR_FORMAT " exited unexpectedly.", p2i(ct));
> 
> This can be placed inside the if-clause where the MutexLocker was.

True. That would be better.

> src/hotspot/share/compiler/compileBroker.cpp line 1136:
> 
>> 1134:       if (ct == NULL) break;
>> 1135:       ThreadsListHandle tlh;  // get_thread_name() depends on the TLH.
>> 1136:       assert(tlh.includes(ct), "ct=" INTPTR_FORMAT " exited unexpectedly.", p2i(ct));
> 
> This can be placed inside the if-clause where the MutexLocker was.

True. That would be better.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2535