RFR: 8262424: Change multiple get_java_xxx() functions in thread.cpp into one function

Thomas Stuefe stuefe at openjdk.java.net
Fri Feb 26 16:53:41 UTC 2021


On Fri, 26 Feb 2021 15:54:07 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Please review this small fix to change the multiple get_java_xxx() functions in thread.cpp into a single function.
>> 
>> The fix was tested with Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows, and tiers 3-5 on Linux x64.
>> 
>> Thanks, Harold
>
> src/hotspot/share/runtime/thread.cpp line 903:
> 
>> 901: char java_runtime_version[128] = "";
>> 902: char java_runtime_vendor_version[128] = "";
>> 903: char java_runtime_vendor_vm_bug_url[128] = "";
> 
> Should these be static?

Why even keep them global? Why not a single temp buffer on the stack inside initialize_java_lang_classes?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2750


More information about the hotspot-runtime-dev mailing list