RFR: 8262424: Change multiple get_java_xxx() functions in thread.cpp into one function

Harold Seigel hseigel at openjdk.java.net
Fri Feb 26 18:07:40 UTC 2021


On Fri, 26 Feb 2021 16:50:42 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Please review this small fix to change the multiple get_java_xxx() functions in thread.cpp into a single function.
>> 
>> The fix was tested with Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows, and tiers 3-5 on Linux x64.
>> 
>> Thanks, Harold
>
> Looks good to me (small remark inline).
> Thanks, Thomas

Hi Thomas,
Thanks for looking at this change.  The 'char java_runtime__[]' buffers need to be global because functions such as JDK_Version::set_java_version(), etc. assign the addresses of these buffers to static char*'s declared in java.hpp.
Harold

-------------

PR: https://git.openjdk.java.net/jdk/pull/2750


More information about the hotspot-runtime-dev mailing list