RFR: 8262424: Change multiple get_java_xxx() functions in thread.cpp into one function

[Coleen Phillimore]

On Fri, 26 Feb 2021 17:05:27 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/runtime/thread.cpp line 907:
>> 
>>> 905: // Extract version and vendor specific information.
>>> 906: static const char* get_java_version_info(InstanceKlass* ik,
>>> 907:                                          Symbol* field_name,
>> 
>> Instead of Symbol* field name, can you pass const char * and use
>> TempNewSymbol field_name = StringTable::new_symbol(name);
>> and then these can be removed from vmSymbols.hpp also?
>
> I think it's better to keep these inside vmSymbols. That way they will be stored inside the CDS archive, and you don't need to create them at runtime. This will save a tiny bit of startup time.

Ok, sure.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2750