RFR: 8258896: Remove the JVM ForceFloatExceptions option [v2]

Harold Seigel hseigel at openjdk.java.net
Tue Jan 5 15:11:56 UTC 2021


On Tue, 5 Jan 2021 05:19:14 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8258896: Remove the JVM ForceFloatExceptions option
>
> src/hotspot/os/windows/os_windows.cpp line 4186:
> 
>> 4184: 
>> 4185:   // for debugging float code generation bugs
>> 4186: #if defined(_DEBUG) && !defined(_WIN64)
> 
> Why `_DEBUG` rather than `ASSERT`?  This would be the only use of `_DEBUG` in all of HotSpot (other than the consistency checking between `PRODUCT`, `ASSERT`, and `_DEBUG` in debug.cpp).  It would also be only the 2nd use of `_DEBUG` in the entire jdk (the other being in the Windows version of libawt).

Thanks Kim.  I changed it from _DEBUB to ASSERT.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1932


More information about the hotspot-runtime-dev mailing list