RFR: 8259392: Zero error reporting is broken after JDK-8255711 [v2]
Aleksey Shipilev
shade at openjdk.java.net
Fri Jan 8 09:15:12 UTC 2021
On Fri, 8 Jan 2021 07:13:54 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Simplify one of the blocks
>
> src/hotspot/os/posix/signals_posix.cpp line 627:
>
>> 625: // reporting code asks e.g. about frames on stack, Zero would experience
>> 626: // a secondary ShouldNotCallThis() crash.
>> 627: VMError::report_and_die(t, sig, pc, info, NULL);
>
> Can't we just use
>
> `ZERO_ONLY(NULL) NOT_ZERO(ucVoid)
>
> ? Or perhaps even:
>
> `ZERO_ONLY(ucVoid = NULL;)
>
> ?
Yeah... Did one of those things. Better?
-------------
PR: https://git.openjdk.java.net/jdk/pull/1980
More information about the hotspot-runtime-dev
mailing list