Integrated: 8234773: Fix ThreadsSMRSupport::_bootstrap_list

[Kim Barrett]

On Mon, 4 Jan 2021 01:29:10 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to ThreadsList and the singleton _bootstrap_list.
> ThreadsList is made noncopyable, with _bootstrap_list changed to be direct
> initialized to avoid referencing the copy constructor.  The ThreadsList
> constructor now uses a static array for the 0-entry case, so that static
> ctor/dtor of _bootstrap_list doesn't involve C-heap allocation.
> 
> Testing:
> mach5 tier1
> 
> Local (linux-x64) build with -fno-elide-constructors and ran hotspot:tier1.
> This has a failure unrelated to this change:
> compiler/intrinsics/klass/CastNullCheckDroppingsTest.java fails with
> #  Internal Error (../../src/hotspot/share/jfr/utilities/jfrVersionSystem.inline.hpp:98), pid=31086, tid=31713
> #  assert(node->_live) failed: invariant
> Filed new bug: https://bugs.openjdk.java.net/browse/JDK-8259036

This pull request has now been integrated.

Changeset: 10a6b0d9
Author:    Kim Barrett <kbarrett at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/10a6b0d9
Stats:     26 lines in 2 files changed: 18 ins; 2 del; 6 mod

8234773: Fix ThreadsSMRSupport::_bootstrap_list

Make ThreadsList noncopyable, direct initializing _bootstrap_list. Avoid C-heap allocation for _bootstrap_list.

Reviewed-by: dholmes, dcubed

-------------

PR: https://git.openjdk.java.net/jdk/pull/1921