RFR: 8259349: -XX:AvgMonitorsPerThreadEstimate=1 does not work right [v5]

[David Holmes]

On 9/01/2021 12:28 pm, Daniel D.Daugherty wrote:
> On Fri, 8 Jan 2021 23:09:15 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> 
>>> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
>>>
>>>    dholmes CR - delete a stale comment.
>>
>> I had a couple of questions.
> 
> I'm really tempted to back out the change that made AvgMonitorsPerThreadEstimate
> an `int` instead of an `intx` and all the associated follow-on changes. Fixing that
> type wasn't the intent of this fix and I'm spending way too much time on stuff that
> has absolutely nothing to do with the bug that I'm trying to solve.

Sorry about that. The cast and the comment about the cast is what jumped 
out at me here. The need for a setter was unclear (and you've now 
explained it is needed for another fix), but the fact the setter takes a 
size_t param to be assigned to a jint field just looks wrong to me. That 
is irrespective of the type of AMPTE.

David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/1992
>