RFR: JDK-8258606: os::print_signal_handlers() should resolve the function name of the handlers [v3]
Thomas Stuefe
stuefe at openjdk.java.net
Mon Jan 11 06:25:54 UTC 2021
On Mon, 4 Jan 2021 18:10:23 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - style changes
>> - Fix Windows gtests
>
> src/hotspot/share/runtime/os.cpp line 909:
>
>> 907: }
>> 908: }
>> 909: st->print("%s+%d", p, offset);
>
> Minor nit -- maybe we should do this to avoid print "+0" all the time?
>
> if (offset == 0) {
> st->print("%s", p);
> } else {
> st->print("%s+%d", p, offset);
> }
You are right, that's better.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1839
More information about the hotspot-runtime-dev
mailing list