RFR: JDK-8259539: JDK-8255711 broke trap messages

[Lois Foltan]

On Mon, 11 Jan 2021 09:20:56 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> SIGTRAP/SIGILL are used on ppc/aarch64 to implement traps in compiled code (print a trap message and stop with a fatal error).
> 
> JDK-8255711 reworked and unified that coding. Calls down into VMError::report_and_die() had been factored out of platform dependent code. Since that change, traps are handled the same as normal crashes, so we loose the detail message associated with a trap. This functionality should be restored.

LGTM with one suggestion.
Lois

src/hotspot/os_cpu/aix_ppc/os_aix_ppc.cpp line 325:

> 323:         ShouldNotReachHere();
> 324: 
> 325:         return false; // Fatal error

In the two files following on you removed the return statement.  For consistency can you do the same here?

-------------

Marked as reviewed by lfoltan (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2022