RFR: 8259349: -XX:AvgMonitorsPerThreadEstimate=1 does not work right [v6]

Coleen Phillimore coleenp at openjdk.java.net
Tue Jan 12 00:07:59 UTC 2021


On Mon, 11 Jan 2021 21:41:23 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> This is a trivial fix to make the "-XX:AvgMonitorsPerThreadEstimate"
>> option work correctly for values < 1024.
>> 
>> I've locally built and tested this fix on my MBP13. It will be included in my
>> next Mach5 Tier[1-3] testing batch.
>
> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
> 
>   change AvgMonitorsPerThreadEstimate from int to size_t and _in_use_list_ceiling from jint to size_t.

I like the new changes!

src/hotspot/share/runtime/globals.hpp line 721:

> 719:           "Used to estimate a variable ceiling based on number of threads " \
> 720:           "for use with MonitorUsedDeflationThreshold (0 is off).")         \
> 721:           range(0, max_uintx)                                               \

This matches all the other size_t ranges.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1992


More information about the hotspot-runtime-dev mailing list