RFR: JDK-8259539: JDK-8255711 broke trap messages [v2]

David Holmes dholmes at openjdk.java.net
Tue Jan 12 09:09:57 UTC 2021


On Tue, 12 Jan 2021 07:36:07 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> SIGTRAP/SIGILL are used on ppc/aarch64 to implement traps in compiled code (print a trap message and stop with a fatal error).
>> 
>> JDK-8255711 reworked and unified that coding. Calls down into VMError::report_and_die() had been factored out of platform dependent code. Since that change, traps are handled the same as normal crashes, so we loose the detail message associated with a trap. This functionality should be restored.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove superfluous return

LGTM.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2022


More information about the hotspot-runtime-dev mailing list