RFR: 8226416: MonitorUsedDeflationThreshold can cause repeated async deflation requests [v5]

Daniel D.Daugherty dcubed at openjdk.java.net
Thu Jan 14 01:02:10 UTC 2021


On Wed, 13 Jan 2021 23:17:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address dholmes CR comments.
>
> src/hotspot/share/runtime/synchronizer.cpp line 1170:
> 
>> 1168:     float remainder = (100.0 - MonitorUsedDeflationThreshold) / 100.0;
>> 1169:     size_t new_ceiling = ceiling + (ceiling * remainder) + 1;
>> 1170:     size_t old_ceiling = ceiling;
> 
> Is that really what you want? `ceiling` may have been assigned again at line 1160.

I misread your comment... Fixing it now...

> test/hotspot/jtreg/runtime/Monitor/MonitorUsedDeflationThresholdTest.java line 48:
> 
>> 46:     public static final int DELAY_SECS = 10;
>> 47:     public static int inflate_count = 0;
>> 48:     public static Object monitors[];
> 
> Style nit: Object[] monitors;

Ahhh.... fixing it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1993


More information about the hotspot-runtime-dev mailing list