RFR: 8134540: Much nearly duplicated code for PerfMemory support [v2]

[Harold Seigel]

On Thu, 14 Jan 2021 08:02:13 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Hi Harold,
>> 
>> I had an initial look. A few comments below.
>> 
>> The amount of Linux specific code is a bit concerning for a shared implementation.
>> 
>> Thanks,
>> David
>
> Hi Harold,
> 
> Sorry I forgot to say thanks for tackling this - deduplication is good! But maybe we can refactor the Linux specific bits more cleanly by pushing helper functions into the os namespace, just for Linux and then calling this via LINUX_ONLY.
> 
> Thanks,
> David

Hi David,
Thanks for your helping improve this change.  This updated change attempts to address your comments.  I reduced the amount of Linux specific bits by using LINUX_ONLY and by moving function get_namespace_pid(int vmid) to os_linux.cpp.  If need be, I'd like to address the remaining LINUX specific code in a separate RFE.

Could you please review this updated commit?

Thanks, Harold

-------------

PR: https://git.openjdk.java.net/jdk/pull/2037