RFR: 8134540: Much nearly duplicated code for PerfMemory support [v2]

[Thomas Stuefe]

On Fri, 15 Jan 2021 14:06:41 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8134540: changes for review comments
>
> src/hotspot/os/posix/os_posix.inline.hpp line 45:
> 
>> 43: 
>> 44: 
>> 45: inline int os::close(int fd) {
> 
> Does this have to be in the inline header? not, simply, os_posix.cpp?

But actually, I believe we should just scrap `os::close(int fd)` altogether. It really does not bring anything to the table. On all platforms its ::close(). Also, we do call raw ::close() in many places anyway, including right here in perf memory code.

Note that this contrasts with os::closedir(), which on Windows has a windows-specific implementation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2037