RFR: JDK-8259569: gtest os.dll_address_to_function_and_library_name_vm fails [v2]

Daniel D.Daugherty dcubed at openjdk.java.net
Fri Jan 15 19:37:08 UTC 2021


On Wed, 13 Jan 2021 06:56:14 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> May I have reviews please for this small and trivial change.
>> 
>> With JDK-8258606 (https://bugs.openjdk.java.net/browse/JDK-8258606), I added a new function to print a function pointer, as well as gtests. Turns out the gtests are too fragile, e.g. depend on the existence of the demangle library on AIX - so I remove some parts of them. 
>> 
>> Thanks, Thomas
>
> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Re-enable gtest
>  - Merge
>  - Initial

Tested with a Mach5 Tier1 job set.
No failures.
gtest/GTestWrapper.java ran in 8 different configs.

Verified that the os.dll_address_to_function_and_library_name_vm subtest passed on macOSX config:

[ RUN ] os.dll_address_to_function_and_library_name_vm
[ OK ] os.dll_address_to_function_and_library_name_vm (22 ms)

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2044


More information about the hotspot-runtime-dev mailing list