RFR: 8134540: Much nearly duplicated code for PerfMemory support [v3]

David Holmes dholmes at openjdk.java.net
Mon Jan 18 05:19:42 UTC 2021


On Fri, 15 Jan 2021 18:35:26 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Please review this change to merge the Unix-like PerfMemory_*.cpp source files into a single PerfMemory_posix.cpp source file.
>> 
>> The changes were tested on Mach5 tiers 1-5 on Linux, Windows, and Mac OS, and cross-builds were done for the S390, arm32, ppc, and x86 platforms.
>> 
>> Thanks, Harold
>
> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8134540 change AIX specific code to use same code as other unix's

Hi Harold,

Thanks for the updates. Still some scope for future refactoring for Linux specific container stuff, but this looks good enough to me.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2037


More information about the hotspot-runtime-dev mailing list