RFR: 8134540: Much nearly duplicated code for PerfMemory support [v3]

[Harold Seigel]

On Tue, 19 Jan 2021 07:13:27 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Hi Harold,
>> 
>> Thanks for the updates. Still some scope for future refactoring for Linux specific container stuff, but this looks good enough to me.
>> 
>> Thanks,
>> David
>
> Hi Harold,
> 
> AIX build breaks with your change because you have a typo there (do you use vi?)
> 
> With this fix it builds:
> 
> --- a/src/hotspot/os/posix/perfMemory_posix.cpp
> +++ b/src/hotspot/os/posix/perfMemory_posix.cpp
> @@ -342,7 +342,7 @@ static DIR *open_directory_secure(const char* dirname) {
>    }
> 
>    // Check to make sure fd and dirp are referencing the same file system object.
> -  if (!is_same_fsobject(fd, AIX_ONLY(dirp->dd_fdi) NOT_AIX(dirfd(dirp)))) {
> +  if (!is_same_fsobject(fd, AIX_ONLY(dirp->dd_fd) NOT_AIX(dirfd(dirp)))) {
>      // The directory is not secure.
>      os::close(fd);
>      os::closedir(dirp);
> 
> No tests ran yet because of this, but I'll reschedule the AIX tests.

Hi Thomas,
Thanks for finding the AIX_ONLY issue.  I"ll fix it before pushing the change.
Harold

-------------

PR: https://git.openjdk.java.net/jdk/pull/2037