RFR: 8223056: Remove Type-Stable-Memory support for Parkers [v2]
Coleen Phillimore
coleenp at openjdk.java.net
Wed Jan 20 13:23:52 UTC 2021
On Tue, 19 Jan 2021 18:58:50 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address Coleen's nit.
>> Move _counter field to Posix PlatformParker class.
>> Rename _ParkEvent to _ParkerEvent on Windows
>
> src/hotspot/os/windows/os_windows.hpp line 205:
>
>> 203: CloseHandle(_ParkEvent);
>> 204: }
>> 205: };
>
> Should the implementation of the constructor and destructor be in the .cpp file so that thread.hpp doesn't need to include whatever windows os specific file needed to import CreateEvent and CloseHandle?
I see there's a lot more work to minimize the include dependencies here.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2089
More information about the hotspot-runtime-dev
mailing list