RFR: 8260256: Leftover Thread uses after JDK-8223657

Aleksey Shipilev shade at openjdk.java.net
Fri Jan 22 15:10:48 UTC 2021


On Thu, 21 Jan 2021 19:41:02 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> JDK-8223657 cleaned up Thread arguments in SymbolTable, but there are some leftovers. Notably, SonarCloud reports that SymbolTableLookup::_thread is not initialized. I looked for `Thread` usages in `symbolTable.cpp`, and it seems only these two are missing. Maybe @coleenp can spot even more omissions somewhere.
>
> src/hotspot/share/classfile/symbolTable.cpp line 351:
> 
>> 349: class SymbolTableLookup : StackObj {
>> 350: private:
>> 351:   Thread* _thread;
> 
> I thought I reviewed this already?

Yes, I missed that #2180 is already there. Closing this one.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2188


More information about the hotspot-runtime-dev mailing list