RFR: 8259845: Move placeholder implementation details to cpp file and add logging

Ioi Lam iklam at openjdk.java.net
Fri Jan 22 21:34:41 UTC 2021


On Fri, 22 Jan 2021 21:17:48 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> See CR for details.
> Tested with tier1-3 and manually by looking at the output.

Marked as reviewed by iklam (Reviewer).

src/hotspot/share/classfile/placeholders.cpp line 269:

> 267: 
> 268: static void log(PlaceholderEntry* entry, const char* function, PlaceholderTable::classloadAction action) {
> 269:   if (log_is_enabled(Debug, class, load, placeholders)) {

Maybe `log()` should be explicitly declared as an inline function, so that the `if (log_is_enabled(Debug, class, load, placeholders))` can be checked without making a function call?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2204


More information about the hotspot-runtime-dev mailing list