RFR: 8249262: Initialize InstanceKlass::_package_entry during CDS dump time [v2]

Calvin Cheung ccheung at openjdk.java.net
Thu Jan 28 01:21:41 UTC 2021


On Wed, 27 Jan 2021 23:57:38 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   1. updates per review comments from Ioi.
>>   2. copyright update.
>
> src/hotspot/share/classfile/systemDictionaryShared.cpp line 1056:
> 
>> 1054: }
>> 1055: 
>> 1056: PackageEntry* SystemDictionaryShared::get_package_entry_from_class_name(InstanceKlass* ik, Handle class_loader) {
> 
> After the parameters changed, the function name is not a good match to it. Should we change the function name?

Hi Yumin,

Thanks for your review.
How about renaming the function to `get_package_entry_from_class`?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2206


More information about the hotspot-runtime-dev mailing list