RFR: 8260264: Move common os_<unix> inline methods to a common posix source file

[David Holmes]

On Wed, 27 Jan 2021 19:14:52 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review this fix for JDK-8260264 to move common functions from os_<unix>.inline.hpp files to os_posix.inline.hpp.  Functions ftruncate() and the two numa* functions could also be moved to os_posix.inline.hpp but would require BSD_ONLY and AIX_ONLY macros because of minor differences.
> 
> The change was tested by running Mach5 tiers 1,2 on Linux, Mac OS, and Windows, and tiers 3-5 on Linux x64.  Additionally, builds were done on Linux-s390x, Linux-ppc, Linux-arm32, and linux-x86.
> 
> Thanks, Harold

Hi Harold,

I would suggest not trying to share the guard-page or shadow-page functions so that all such functions reside together in the OS specific header file, and you can see the full situation at a glance.

The I/O function changes seem mostly okay but in a couple of cases you have replaced ::foo64 with ::foo and it is not obvious that is a correct change to make, so please confirm that.

Minor macro use is acceptable if you want to look again at the NUMA and ftruncate cases.

Thanks,
David

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2267