RFR: 8259839 SystemDictionary exports too much implementation [v2]
Coleen Phillimore
coleenp at openjdk.java.net
Thu Jan 28 13:32:47 UTC 2021
On Wed, 27 Jan 2021 11:24:30 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> src/hotspot/share/classfile/systemDictionary.cpp line 414:
>>
>>> 412: // if super_name, & class_loader don't match:
>>> 413: // if initial define, SD update will give LinkageError
>>> 414: // if redefine: compare_class_versions will give HIERARCHY_CHANGED
>>
>> Should these comment lines be indented because they describe what happens when super_name and loader don't match?
>> I find these comments are bit hard to parse in their existing form of psuedo-English.
>
> I was going to rewrite several comments in another pass. I think the detail about redefinition isn't useful here because it's implemented somewhere else, and this code has no effect in that regard.
fixed this.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2247
More information about the hotspot-runtime-dev
mailing list