RFR: 8259839 SystemDictionary exports too much implementation [v3]

[Coleen Phillimore]

On Thu, 28 Jan 2021 05:41:19 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix comments and verify_placeholder
>>  - Fix handle_resolution_exception to make more sense.
>
> src/hotspot/share/classfile/systemDictionary.cpp line 2028:
> 
>> 2026: // Verify that this placeholder exists since this class is in the middle of loading.
>> 2027: void verify_placeholder(Symbol* class_name, ClassLoaderData* loader_data) {
>> 2028:   // Only parallel capable class loaders use placeholder table for define class.
> 
> Maybe I'm having trouble following the call sequence, but non-parallel capable loaders also add placeholder entries, and then call check_constraints. So why do we not need to verify the placeholder in that case?

Non-parallel capable class loaders do NOT add placeholder entries for DEFINE_CLASS (capitalized because that's the enum).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2247