RFR: 8259839 SystemDictionary exports too much implementation [v2]

Coleen Phillimore coleenp at openjdk.java.net
Thu Jan 28 13:32:46 UTC 2021


On Wed, 27 Jan 2021 05:00:41 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   return NULL for find_or_define_helper if pending exception
>
> src/hotspot/share/classfile/systemDictionary.cpp line 241:
> 
>> 239: static Klass* handle_resolution_exception(Symbol* class_name, bool throw_error, Klass* klass, TRAPS) {
>> 240:   if (HAS_PENDING_EXCEPTION) {
>> 241:     assert(klass == NULL, "Should not have result with exception pending");
> 
> If klass is expected to be NULL why even bother passing it in to this function?

I rewrote this a bit, see new commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2247


More information about the hotspot-runtime-dev mailing list