RFR: 8259839 SystemDictionary exports too much implementation [v3]

Coleen Phillimore coleenp at openjdk.java.net
Thu Jan 28 17:27:42 UTC 2021


On Thu, 28 Jan 2021 05:42:19 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Also there is a comment block at line 759 that says 5 cases ... but only lists 4.

I was going to hold off rewriting that comment but I did so anyway.  There are 3 cases as far as I can tell and some subtleties with the three.  You can have a parallelCapable class loader but we still take out a LOAD_INSTANCE placeholder token because we don't know that your parallelCapable class loader has a lock.  So we have the placeholder, but it still allows multiple loadClass calls in parallel and will get an error somewhere else (I think).  This is a strange path through the code.  I'll update the comment when I confirm (to hopefully avoid spamming the whole list).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2247


More information about the hotspot-runtime-dev mailing list