RFR: JDK-8260625: Rename MetaspaceExpand_lock

Yumin Qi minqi at openjdk.java.net
Fri Jan 29 19:00:43 UTC 2021


On Fri, 29 Jan 2021 06:40:49 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Hi, may I have reviews please for this trivial change:
> 
> MetaspaceExpand_lock is a potentially confusing misnomer for the casual code reader, since it does not only guard metaspace expansion but guards access to all central metaspace structures for expansion, reclamation, access to freelist etc. 
> 
> With this patch it is renamed to the more generic "Metaspace_lock".
> 
> Thanks, Thomas

LGTM.

test/hotspot/gtest/metaspace/test_virtualspacenode.cpp line 3:

> 1: /*
> 2:  * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved.
> 3:  * Copyright (c) 2020, 2021 SAP SE. All rights reserved.

There should add a ',' after 2021

-------------

PR: https://git.openjdk.java.net/jdk/pull/2308


More information about the hotspot-runtime-dev mailing list