RFR: JDK-8260625: Rename MetaspaceExpand_lock

[Yumin Qi]

Thanks, now I know:)


Yumin

On 1/29/21 11:19 AM, Coleen Phillimore wrote:
>
>
> On 1/29/21 2:00 PM, Yumin Qi wrote:
>> On Fri, 29 Jan 2021 06:40:49 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>>
>>> Hi, may I have reviews please for this trivial change:
>>>
>>> MetaspaceExpand_lock is a potentially confusing misnomer for the casual code reader, since it does not only guard metaspace expansion but guards access to all central metaspace structures for expansion, reclamation, access to freelist etc.
>>>
>>> With this patch it is renamed to the more generic "Metaspace_lock".
>>>
>>> Thanks, Thomas
>> LGTM.
>>
>> test/hotspot/gtest/metaspace/test_virtualspacenode.cpp line 3:
>>
>>> 1: /*
>>> 2:  * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved.
>>> 3:  * Copyright (c) 2020, 2021 SAP SE. All rights reserved.
>> There should add a ',' after 2021
>
> Turns out that the SAP copyright doesn't have the trailing comma. Now you know :)
> Coleen
>>
>> -------------
>>
>> PR: https://git.openjdk.java.net/jdk/pull/2308
>