RFR: 8213226: [TESTBUG] Reduce the usage of CDSTestUtils.executeAndLog()

Yumin Qi minqi at openjdk.java.net
Fri Jan 29 22:40:40 UTC 2021


On Thu, 28 Jan 2021 18:44:45 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> Please review this CDS tests cleanup for reducing the usage of `CDSTestUtils.executeAndLog()` by making use of `CDSTestUtils.run()`, `CDSTestUtils.createArchiveAndCheck()`, etc.
> 
> Testing: tiers 1 - 4.

test/hotspot/jtreg/runtime/cds/SharedStrings.java line 59:

> 57:             // Set CDSOptions.xShareMode to "off" so that the result checking
> 58:             // would not always expect the word "sharing" in the output.
> 59:             .setXShareMode("off")

According to CDSTestUtils.runWithArchive:
      for (String p : opts.prefix) cmd.add(p);

        cmd.add("-Xshare:" + opts.xShareMode);
The -Xshare::off will be the last one for share mode setting, so this test will be always with shared  mode off?  Unless the suffix include share setting to change that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2297


More information about the hotspot-runtime-dev mailing list