RFR: 8269135: TestDifferentProtectionDomains runs into timeout in client VM [v2]

Daniel D.Daugherty dcubed at openjdk.java.net
Fri Jul 2 15:14:58 UTC 2021


On Wed, 23 Jun 2021 10:44:53 GMT, Christoph Göttschkes <cgo at openjdk.org> wrote:

>> The test tries to compile a method using the WhiteBox with optimization level 4, which is not available in client VMs. The WhiteBox only prints out a warning, and the call to enqueueMethodForCompilation succeeds. After that, the test case goes into an endless loop to wait for the compilation to finish, which never happens, because the method is not enqueued for compilation.
>> 
>> I fixed this by choosing a different compilation level, if C2 is not included in the JVM. I think this test should be enough, since there is already an `@requires` which checks, that we are in mixed mode and that C2 should be used.
>> 
>> In addition, I bound the loop in order to fail with a timeout more early, if the compilation does not happen (or takes too long because of platform restrictions).
>
> Christoph Göttschkes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adds requires compiler2 & revert compilation level detection.

HotSpot changes require two reviewers and it doesn't look
like @eastig has marked this PR as reviewed.

I've gone ahead and reviewed your changes. Thumbs up.

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4558


More information about the hotspot-runtime-dev mailing list