RFR: 8230797: ARM32-softfp: assertion in InterpreterRuntime::resolve_ldc [v2]

Christoph Göttschkes cgo at openjdk.java.net
Tue Jul 6 13:17:17 UTC 2021


On Tue, 6 Jul 2021 00:29:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Christoph Göttschkes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adds an additional NULL check for the CP _cache.
>
> src/hotspot/share/interpreter/interpreterRuntime.cpp line 193:
> 
>> 191:     Bytecode_loadconstant ldc2(m, last_frame.bci());
>> 192:     int rindex = ldc2.cache_index();
>> 193:     if (rindex < 0 && m->constants()->resolved_references() != NULL)
> 
> Should be `resolved_references_or_null()`

I think the cache should always be initialized. The problem are the resolved symbols in the cache. But I don't see any harm in adding this check as well.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4582


More information about the hotspot-runtime-dev mailing list