RFR: 8263538: SharedArchiveConsistency.java should test -Xshare:auto as well

Yumin Qi minqi at openjdk.java.net
Tue Jul 6 21:59:52 UTC 2021


On Tue, 6 Jul 2021 21:25:04 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Hi, please review
>> 
>>   When this test run with -Xshare:on, it will exit when the shared archive is corrupted or mismatch. Make it run with -Xshare:auto will expand code coverage and to keep app run without using the CDS.
>> 
>>   Tests: Mach5 tier1,tier4
>> 
>> Thanks
>> Yumin
>
> test/hotspot/jtreg/runtime/cds/appcds/SharedArchiveConsistency.java line 437:
> 
>> 435:         if (!shareAuto) {
>> 436:           output.shouldContain("Hello World");
>> 437:         }
> 
> Are lines 431-437 still necessary, now that both -Xshare:on and -Xshare:off are already executed for this test scenario.

I was thinking of that either, the comment said using same archive. The other run with new created archive ---- though they have same contents. I could delete this part.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4694


More information about the hotspot-runtime-dev mailing list