RFR: 8264735: Make dynamic dump repeatable [v2]

Yumin Qi minqi at openjdk.java.net
Tue Jul 6 23:05:56 UTC 2021


On Tue, 6 Jul 2021 21:40:46 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix comments, added check holding for DumpTimeTable_lock
>
> src/hotspot/share/cds/dynamicArchive.cpp line 168:
> 
>> 166: 
>> 167:     // Restore dumptime tables
>> 168:     SystemDictionaryShared::restore_dumptime_tables();
> 
> Maybe this should be put inside post_dump as well?

It would be better to keep it here with SystemDictionaryShared::clone_dumptime_table().

-------------

PR: https://git.openjdk.java.net/jdk/pull/4646


More information about the hotspot-runtime-dev mailing list