RFR: 8268635: Corrupt oop in ClassLoaderData [v2]

Xin Liu xliu at openjdk.java.net
Wed Jul 7 07:06:59 UTC 2021


On Wed, 7 Jul 2021 01:31:07 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> We worked on writing a test for this but weren't successful.  Based on analysis by @stefank this missing call may have been the cause of the crash.
>> Tested with tier1-3.
>
> Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8268635: Corrupt oop in ClassLoaderData

Hi, Coleen, 

Thank you for taking this issue.  your code change looks good to me.  

IIUC, this PR covers the code path from`ModuleEntry::set_shared_protection_domain`, where needs record_modified_oops(). 
ClassLoaderData::record_dependency() seems to have a redundant `record_modified_oops`, but I don't think it affects correctness. 

thanks,
--lx

-------------

PR: https://git.openjdk.java.net/jdk/pull/4701


More information about the hotspot-runtime-dev mailing list