RFR: 8264735: Make dynamic dump repeatable [v3]
Ioi Lam
iklam at openjdk.java.net
Wed Jul 7 19:26:59 UTC 2021
On Wed, 7 Jul 2021 14:59:19 GMT, Yumin Qi <minqi at openjdk.org> wrote:
>> Hi, Please review
>>
>> Currently after dynamic dump, dump time tables (`_dumptime_talbles, _dumptime_lambda_proxy_class_dictionary and _saved_shared_path_table`) are corrupted and could not be used for next dump. The patch clones the three tables, and after dump restore them so the next dump is possible. With the fix, jcmd VM.cds dynamic_dump can do multiple dump to the same live process.
>>
>> Tests: tier1,tier2,tier3,tier4
>>
>> Thanks
>> Yumin
>
> Yumin Qi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Save SharedPathTable array for later reclaim, remove comments for ctors
> - Merge branch 'master' into jdk-8264735
> - Fix comments, added check holding for DumpTimeTable_lock
> - 8264735: Make dynamic dump repeatable
LGTM
-------------
Marked as reviewed by iklam (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4646
More information about the hotspot-runtime-dev
mailing list