RFR: 8267281: Call prepare_for_dynamic_dumping for jcmd dynamic_dump [v2]
Yumin Qi
minqi at openjdk.java.net
Mon Jul 12 19:08:57 UTC 2021
On Mon, 12 Jul 2021 18:25:16 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Modified log message and test case for checking this message
>
> src/hotspot/share/cds/metaspaceShared.cpp line 597:
>
>> 595: void MetaspaceShared::link_shared_classes(TRAPS) {
>> 596: // Collect all loaded ClassLoaderData.
>> 597: ResourceMark rm;
>
> (This is pre-existing) I think the ResourceMark can be removed.
The function is called by both static and dynamic dump, for dynamic caller already set ResourceMark, but static. I will leave this as it is, it may need more check to see if it should be removed. Maybe it can be removed since I did not see any use of the it in the call and its callees.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4736
More information about the hotspot-runtime-dev
mailing list