[jdk17] RFR: 8269865: Async UL needs to handle ERANGE on exceeding SEM_VALUE_MAX [v7]

Xin Liu xliu at openjdk.java.net
Wed Jul 14 01:38:41 UTC 2021


On Tue, 13 Jul 2021 23:47:17 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Replace counting semaphore with os::PlatformMontor.
>>   
>>   Second attempt. This patch also removed semaphore-based lock because
>>   PlatformMonitor can also be used as a Mutex lock.
>
> src/hotspot/share/logging/logAsyncWriter.hpp line 139:
> 
>> 137:   static AsyncLogWriter* _instance;
>> 138:   Semaphore _flush_sem;
>> 139:   os::PlatformMonitor _lock;
> 
> Please add a comment before this:
> 
> // Can't use a Monitor here as we need a low-level API that can be used
> // late in a thread's termination process.

done.

-------------

PR: https://git.openjdk.java.net/jdk17/pull/216


More information about the hotspot-runtime-dev mailing list