RFR: 8270333: -XX:+VerifyStringTableAtExit should not do linear search [v2]

Ioi Lam iklam at openjdk.java.net
Wed Jul 14 05:37:57 UTC 2021


On Wed, 14 Jul 2021 05:09:41 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   replace template with inline function
>
> src/hotspot/share/classfile/javaClasses.cpp line 506:
> 
>> 504: 
>> 505: template<bool update>
>> 506: unsigned int java_lang_String::hash_code_impl(oop java_string) {
> 
> This looks like a really weird way to pass a parameter! Why do we want a template here?

Hi David, thanks for the review. I replaced the template function with an inline function.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4772


More information about the hotspot-runtime-dev mailing list