RFR: 8270333: -XX:+VerifyStringTableAtExit should not do linear search [v3]

Ioi Lam iklam at openjdk.java.net
Wed Jul 14 16:45:52 UTC 2021


On Wed, 14 Jul 2021 15:03:52 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed build and make sure table size is not zero
>
> src/hotspot/share/classfile/stringTable.cpp line 613:
> 
>> 611:  public:
>> 612:   size_t _errors;
>> 613:   VerifyCompStrings() : _table(unsigned(_items_count + 8 / 8)), _errors(0) {}
> 
> I guess you mean unsigned((_items_count + 8) / 8)?

Thanks for the review. I changed it to `_table(unsigned(_items_count / 8) + 1)`

-------------

PR: https://git.openjdk.java.net/jdk/pull/4772


More information about the hotspot-runtime-dev mailing list