RFR: 8268773: Improvements related to: Failed to start thread - pthread_create failed (EAGAIN) [v2]

[David Holmes]

On Tue, 6 Jul 2021 22:42:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Please review this simple enhancement that:
>> 
>> 1. Retries OS thread creation of it fails due to EAGAIN
>> 
>> This is potentially of limited use as you would need some resources to be released for subsequent calls to succeed.
>> 
>> 2. Prints the name of the thread being started in the warning/log messages
>> 
>> This is also of limited use as JavaThread's do not have their correct name at this stage, nor do some system threads. But others do, so it can be informative.
>> 
>> I looked at trying to (separately) unify this code into a Posix version, but the platform differences are such that it makes it very difficult to try and share code. So this simply updates each the existing code in place.
>> 
>> Testing: 
>>   - builds from tiers 1-3 and GHA
>>   - manual inspection of output from a simple thread exhaustion test (runtime/Thread/ThreadCountLimit.java)
>>   - manual inspection of os+thread logging on java -version
>> 
>> Thanks,
>> David
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update expected output now that thread name is included

I'm closing this PR to retackle the logging updates a different way, in different locations where more information is available - at least for JavaThreads.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4648