[jdk17] RFR: 8271093: remove deadcode from runtime/Thread/TestThreadDumpSMRInfo.java test

Igor Ignatyev iignatyev at openjdk.java.net
Wed Jul 21 23:26:48 UTC 2021


On Wed, 21 Jul 2021 23:19:30 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Hi all,
>> 
>> could you please review this trivial test-only clean-up?
>> from JBS:
>>> TestThreadDumpSMRInfo::usage isn't used by anyone and should be removed
>> 
>> 
>> PS alternatively, `TestThreadDumpSMRInfo::usage` can be called in an else branch at L70, but I don't see much point in that
>> 
>> Thanks,
>> -- Igor
>
> Hi @iignatev ,
> 
> I'm not sure changes like this should go into jdk17 since we are already in RDP2 [1].
> Thanks.
> 
> [1] https://mail.openjdk.java.net/pipermail/jdk-dev/2021-July/005758.html

Hi @DamonFool ,

according to JEP3, P1–P5 doc/test bugs are allowed in RDP2[1] and do not require approval. so I don't see any reason why it should not go into jdk17.

Thanks,
-- Igor

[1] https://openjdk.java.net/jeps/3#rdp-2
[2] https://openjdk.java.net/jeps/3#Test-and-documentation-bugs

-------------

PR: https://git.openjdk.java.net/jdk17/pull/265


More information about the hotspot-runtime-dev mailing list