[jdk17] RFR: 8271093: remove deadcode from runtime/Thread/TestThreadDumpSMRInfo.java test

[Daniel D.Daugherty]

On Wed, 21 Jul 2021 23:03:46 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

> Hi all,
> 
> could you please review this trivial test-only clean-up?
> from JBS:
>> TestThreadDumpSMRInfo::usage isn't used by anyone and should be removed
> 
> 
> PS alternatively, `TestThreadDumpSMRInfo::usage` can be called in an else branch at L70, but I don't see much point in that
> 
> Thanks,
> -- Igor

Thumbs up.

Looks good to me also.

I usually have those usage() calls in with the argument processing logic.
The proper place is in an else branch at L70 (as you mentioned). I wonder
if I forgot to do it or if I somehow lost those lines before integrating the
test (so very long ago...).

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk17/pull/265