[jdk17] RFR: 8271160: runtime/jni/checked/TestCheckedJniExceptionCheck.java doesn't set -Djava.library.path

Igor Ignatyev iignatyev at openjdk.java.net
Thu Jul 22 21:57:09 UTC 2021


On Thu, 22 Jul 2021 21:46:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

> I also don't think the lack of checking for a zero exit code would cause this to spuriously pass either as there is expected output that would not be found if the test failed with UnsatisfiedLinkException due to the native library.


Hi David,

the lack of checking is exactly how I found this issue. the test passed as it skipped all its checks in `checkOuputForCorrectWarnings` b/c it didn't meet "TEST STARTED" line. I guess we can improve  `checkOuputForCorrectWarnings` to be more rigid in its check.

Thanks,
-- Igor

-------------

PR: https://git.openjdk.java.net/jdk17/pull/273


More information about the hotspot-runtime-dev mailing list