[jdk17] RFR: 8271160: runtime/jni/checked/TestCheckedJniExceptionCheck.java doesn't set -Djava.library.path [v2]
David Holmes
dholmes at openjdk.java.net
Thu Jul 22 22:19:36 UTC 2021
On Thu, 22 Jul 2021 22:15:43 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
>> Hi all,
>>
>> could you please review this small patch that sets `-Djava.library.path` to ` test.nativepath` for `TestCheckedJniExceptionCheck`'s child JVM so it will be able to locate the library?
>>
>> from JBS:
>>> TestCheckedJniExceptionCheck spawns a child JVM that uses a test native library, TestCheckedJniExceptionCheck, but it doesn't add/set test.nativepath value to -Djava.library.path, so the child JVM can't find the library and fails.
>>>
>>> this issue hasn't been noticed early b/c TestCheckedJniExceptionCheck doesn't check the exit code of the child JVM.
>>
>> Thanks,
>> -- Igor
>
> Igor Ignatyev has updated the pull request incrementally with one additional commit since the last revision:
>
> check that TEST_START has been met
Update looks good.
Thanks,
David
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk17/pull/273
More information about the hotspot-runtime-dev
mailing list